Package suggested git script with Python package #15
Conversation
The only idea I might have is to create a separate package with only the bash script and depend on it in an extra. But... meh. |
joao-p-marques
force-pushed
the
bundle-git-script
branch
from
1f3c51f
to
9da8cd3
Compare
|
@sbidoul Maybe not the most elegant solution, but I just added the option to explicitly opt-in to the script replacement through a shell variable... |
joao-p-marques
force-pushed
the
bundle-git-script
branch
2 times, most recently
from
9cd810b
to
79dab85
Compare
| if [[ "$GIT_AUTOSHARE" == "1" && "$1" == "clone" ]] | ||
| then | ||
| shift | ||
| /usr/bin/git autoshare-clone "$@" |
There was a problem hiding this comment.
We don't want to affect people with git in other paths.
| /usr/bin/git autoshare-clone "$@" | |
| "$0" autoshare-clone "$@" |
| shift | ||
| /usr/bin/git autoshare-clone "$@" | ||
| else | ||
| /usr/bin/git "$@" |
There was a problem hiding this comment.
| /usr/bin/git "$@" | |
| "$0" "$@" |
There was a problem hiding this comment.
This won't work I am afraid, as $0 (git) will resolve to the current script and cause a loop...
There was a problem hiding this comment.
Maybe shomething like
| /usr/bin/git "$@" | |
| ${GIT_BIN:-/usr/bin/git} "$@" |
??
joao-p-marques
force-pushed
the
bundle-git-script
branch
from
79dab85
to
e014d09
Compare
As suggested in acsone/git-aggregator#55
@sbidoul @yajo this solves the problem by using a pure Bash script. However, I still haven't found a way of making it optional on install... Any ideas?
Some notes on what was already explored:
gitcommand is not viable due to Python load times.setuptoolsallows you to define optional commands to be insatalled, but AFAIK only throughentry_points, which is only meant for Python modules.git clone(git-clone) as that would not introduce more delays thatautoshareitself and it would only affect thecloneoperation. However, even when I havegit-clonein the path,git clonestill redirects to the normal command. I guess it is one of those subcommands that can't be replaced...@Tecnativa
TT32042